jojochuang commented on code in PR #11656:
URL: https://github.com/apache/ozone/pull/11656#discussion_r4403803731


##########
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/NodeDetails.java:
##########
@@ -45,7 +45,8 @@ public NodeDetails(String serviceId, String nodeId,
     this.nodeId = nodeId;
     this.rpcAddress = rpcAddress;
     if (rpcAddress != null) {
-      this.hostAddress = rpcAddress.getHostName();
+      // Keep the configured host. getHostName() would replace an IP literal 
with its reverse DNS name.
+      this.hostAddress = rpcAddress.getHostString();

Review Comment:
   getHostName() may trigger a name reverse lookup if the address is created 
with literal IP, whereas getHostString() doesn't.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to