jojochuang commented on PR #11656: URL: https://github.com/apache/ozone/pull/11656#issuecomment-6476157170
Non-blocking, nice-to-have, and unrelated to this PR's fix: could we consider validating `rpcAddress` in the constructor that accepts an `InetSocketAddress`? If null is passed to that constructor, `hostAddress` remains unset, so an incomplete node definition fails later during address construction. An explicit `Objects.requireNonNull(rpcAddress, "rpcAddress == null")` would give a clearer error at the source, provided no callers intentionally rely on that case. This would be specific to the socket-address constructor; the separate host-string constructor intentionally supports lazy initialization of `rpcAddress`. This can be handled separately and does not block this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
