andyhuangdev commented on code in PR #11585:
URL: https://github.com/apache/ozone/pull/11585#discussion_r4312675896
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java:
##########
@@ -87,7 +87,14 @@ protected synchronized void run() {
wait(interval);
long startTime, endTime, duration, durationMilliseconds;
startTime = System.nanoTime();
- initializeAndRunTask();
+ try {
+ initializeAndRunTask();
+ } catch (Exception e) {
+ LOG.error("Failed to run Container Size Distribution task.", e);
Review Comment:
Thanks for the review. Agreed, I’ll move the common exception handling into
ReconScmTask so all three tasks can recover from failed runs, while preserving
interruption handling and the retry interval. I’ll keep the container size
count reset in ContainerSizeCountTask, since it is needed to rebuild consistent
counts after partial database writes, and update the tests accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
