devmadhuu commented on code in PR #11322:
URL: https://github.com/apache/ozone/pull/11322#discussion_r4209979062


##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -608,6 +608,16 @@ message VolumeReportProto {
     optional uint64 effectiveUsedSpace = 6;
     optional double utilization = 7;
     optional uint64 ozoneAvailable = 8;
+    optional StorageTypeProto storageType = 9;
+}
+
+message StorageTypeDiskBalancerInfoProto {

Review Comment:
   Checked the existing messages. `VolumeReportProto` describes a single 
physical volume (storageId, storagePath), and `DatanodeUsageInfoProto` carries 
per-datanode absolute byte counts plus DatanodeDetailsProto. The new message is 
an aggregate across all volumes of one storage type, and four of its six fields 
— `currentVolumeDensitySum, idealUsage, usableVolumeCount, balanceable ` -  
have no counterpart in either. Reusing one would mean adding those fields to a 
message where its own existing fields don't apply, so I've kept the new 
message. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to