Gargi-jais11 commented on code in PR #11322:
URL: https://github.com/apache/ozone/pull/11322#discussion_r4195010078
##########
hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/diskbalancer/TestDefaultContainerChoosingPolicy.java:
##########
@@ -452,6 +459,79 @@ public void testChooseVolumesSkipsZeroCapacityVolume()
throws IOException {
assertNull(result);
}
+ /**
+ * With volumes of two StorageTypes, the chosen pair comes from a single
type. Here the SSD volumes
+ * have the widest utilization spread, so SSD is balanced first.
+ */
Review Comment:
this comment is somewhat wrong and gives the wrong reason SSD is picked.
SSD is picked because SSD comes before DISK in the enum, not because of the
spread. I think we can test this if u swap the numbers (DISK spread 0.60 to
0.20, SSD spread 0.75 to 0.50) and SSD is still chosen. The test passes either
way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
