Gargi-jais11 commented on code in PR #11322: URL: https://github.com/apache/ozone/pull/11322#discussion_r4194990318
########## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/diskbalancer/DiskBalancerService.java: ########## Review Comment: **DiskBalancerService#getDiskBalancerInfo**, **calculateVolumeDataDensity** and **calculateBytesToMove** still compute ideal usage, bytes to move and volume data density across all volumes. These values are shown by `ozone admin datanode diskbalancer status and report`. We should compute these values per storage type, using the same grouping and the same rule of skipping types with fewer than two volumes. And accordingly in the cli output we should add a field as storageType in report and status command. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
