peterxcli commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2093878178
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -521,6 +521,28 @@ public void testEncodingTypeException() throws IOException
{
assertEquals(S3ErrorTable.INVALID_ARGUMENT.getCode(), e.getCode());
}
+ @Test
Review Comment:
> Since the unit test does not initialize the maxKeysLimit config, the robot
test is better suited to verify this behavior.
@Jimmyweng006 Use
[setConfig](https://github.com/apache/ozone/blob/8ceb5c319768d684d95a115f1a6bb023465b3d93/hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/EndpointBuilder.java#L57-L60)
of the builder to set the config with custom lower max key limit, then call
`bucketEndpoint#init`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org
