Jimmyweng006 commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2083081194


##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestBucketList.java:
##########
@@ -521,6 +521,28 @@ public void testEncodingTypeException() throws IOException 
{
     assertEquals(S3ErrorTable.INVALID_ARGUMENT.getCode(), e.getCode());
   }
 
+  @Test

Review Comment:
   1. The max-keys config is already covered by the Robot test "List objects 
with max-keys exceeding config limit should not return more than limit". Since 
the unit test does not initialize the maxKeysLimit config, the robot test is 
better suited to verify this behavior.
   
   2. For the low value it can still be controlled by 
ozone.s3g.list.max.keys.limit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org

Reply via email to