Re: [PR] HDDS-12870. Fix listObjects corner cases [ozone]

[via GitHub]

Jimmyweng006 commented on code in PR #8307:
URL: https://github.com/apache/ozone/pull/8307#discussion_r2062491345


##########
hadoop-ozone/s3gateway/src/main/java/org/apache/hadoop/ozone/s3/endpoint/BucketEndpoint.java:
##########
@@ -292,6 +294,14 @@ public Response get(
     return Response.ok(response).build();
   }
 
+  private int validateMaxKeys(int maxKeys) throws OS3Exception {
+    if (maxKeys <= 0) {
+      throw S3ErrorTable.newError(S3ErrorTable.INVALID_ARGUMENT, "maxKeys must 
be > 0");
+    }
+
+    return Math.min(maxKeys, 1000);

Review Comment:
   Configurable maxKey test result with some local log
   
![image](https://github.com/user-attachments/assets/cdea7c1f-dfe3-4a73-901a-4077d53d989e)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.org
For additional commands, e-mail: issues-h...@ozone.apache.org