devmadhuu commented on PR #7942: URL: https://github.com/apache/ozone/pull/7942#issuecomment-2687754463
> [#7942 (comment)](https://github.com/apache/ozone/pull/7942#discussion_r1965565445) made me realise that with introducing the `REPLICA_MISMATCH` state we'll be able to have containers that are in two unhealthy state at the same time, e.g. a container can be over replicated and it could have a replica checksum mismatch. I think this couldn't happen before with these states > > https://github.com/apache/ozone/blob/59aaa5cdb078f52c880fbed945f3aa8afbabe9d1/hadoop-ozone/recon-codegen/src/main/java/org/apache/ozone/recon/schema/ContainerSchemaDefinition.java#L46-L54 > > What do you think, how should we handle this? It should be in both states and it should show up in both unhealthy container tables, right? We have stats for each container state count and the overall count, how should we do that? Count it to both states, but we shouldn't count them twice to the overall count? > I'll look over my patch and check if I should change anything based on this, as I think this will bring new scenarios into the picture, how the unhealthy containers are handled in Recon. Let me know if I miss something. As far as I know, I think , we add the record per container per state in `UNHEALTHY_CONTAINERS` table. Can you pls check [this](https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java#L279) and [this](https://github.com/apache/ozone/blob/master/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java#L246) code ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
