dombizita commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1971876026
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHistory.java:
##########
@@ -100,4 +103,12 @@ public String getState() {
public void setState(String state) {
this.state = state;
}
+
+ public long getDataChecksum() {
+ return dataChecksum;
+ }
+
+ public void setDataChecksum(long dataChecksum) {
+ this.dataChecksum = dataChecksum;
+ }
Review Comment:
I looked into this now and tried to figure out why do we have both the
`ContainerReplicaHistory` and the `ContainerHistory` classes. First of all, I
believe `ContainerHistory` is also used for container replicas (name is
confusing...)
https://github.com/apache/ozone/blob/1d82fe25228654751f278d42a96dc088427c9429/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/persistence/ContainerHistory.java#L23-L30
Right now we need the `dataChecksum` in `ContainerHistory`, because here we
are returning `ContainerHistory`s (and I added `dataChecksum` in my patch here)
and we use those in the `ContainerEndpoint` later (that's how we will be able
to map the datanodes to the container replicas in the UI):
https://github.com/apache/ozone/blob/59aaa5cdb078f52c880fbed945f3aa8afbabe9d1/hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconContainerManager.java#L393-L394
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
