devmadhuu commented on code in PR #7942:
URL: https://github.com/apache/ozone/pull/7942#discussion_r1972953699
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/fsck/ContainerHealthTask.java:
##########
@@ -650,6 +665,17 @@ private static boolean keepMisReplicatedRecord(
return false;
}
+ private static boolean keepReplicaMismatchRecord(
+ ContainerHealthStatus container, UnhealthyContainersRecord rec) {
+ if (container.isDataChecksumMismatched()) {
+ updateExpectedReplicaCount(rec, container.expectedPlacementCount());
+ updateActualReplicaCount(rec, container.actualPlacementCount());
+ updateReplicaDelta(rec, container.replicaDelta());
Review Comment:
Since we are updating expected replica count, actual replica count and
replica delta here, we need to use below:
```
updateExpectedReplicaCount(rec, container.getReplicationFactor());
updateActualReplicaCount(rec, container.getReplicaCount());
updateReplicaDelta(rec, container.replicaDelta());
```
You are updating expected placement count, actual placement count which is
not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
