martinzink commented on code in PR #2246: URL: https://github.com/apache/nifi-minifi-cpp/pull/2246#discussion_r3892648530
########## minifi_rust/extensions/minifi_rs_playground/src/processors/put_file/processor_definition.rs: ########## Review Comment: reverted in [revert const PROPERTIES -> const fn properties()](https://github.com/apache/nifi-minifi-cpp/pull/2246/commits/b0656f941c1a606979913ccf78387770d07eb11d) ########## minifi_rust/extensions/minifi_rs_playground/src/processors/generate_flow_file/processor_definition.rs: ########## Review Comment: they are changed so they can be manipulated in const context, e.g. composite processor with all of properties of its components, I've reverted this change in this PR will post it where its more relevant (first composite processor) so we can discuss the pros and cons -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
