fgerlits commented on code in PR #2246: URL: https://github.com/apache/nifi-minifi-cpp/pull/2246#discussion_r3873541493
########## minifi_rust/extensions/minifi_rs_playground/src/processors/put_file/processor_definition.rs: ########## Review Comment: What was the reason for the `const PROPERTIES` to `fn properties()` change? It seems unrelated to the rest of the PR. Avoiding duplication is good, but the new code is more complex, and (at least for me) harder to read. I would revert this part of the change, if it isn't needed for the main error-handling change. ########## minifi_rust/minifi_native/src/api/processor_wrappers/utils/with_attributes.rs: ########## Review Comment: This attribute handling change looks unrelated to the error handling change. This could have gone into a separate PR, but since it's included here, please mention it in the commit message. Also, I can't find any calls to these generated functions. It would be good to call them from a few unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
