martinzink commented on code in PR #2246:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2246#discussion_r3925774568
##########
minifi_rust/minifi_native/src/api/processor_wrappers/flow_file_source.rs:
##########
@@ -17,56 +17,56 @@
use crate::api::processor_wrappers::utils::flow_file_content::Content;
use crate::api::raw_processor::{MultiThreadedTrigger, SingleThreadedTrigger};
+use crate::{FlowFileAttribute, impl_with_attributes};
use crate::{
GetControllerService, GetProperty, Logger, MinifiError, MultiThreaded,
OnTriggerResult,
- ProcessContext, ProcessSession, Processor, Relationship, Schedule,
SingleThreaded,
+ ProcessContext, ProcessError, ProcessSession, Processor, Relationship,
Schedule,
+ SingleThreaded,
};
-use std::collections::HashMap;
+use std::borrow::Cow;
pub struct GeneratedFlowFile<'a> {
- target_relationship_name: &'static str,
+ target_relationship_name: Cow<'static, str>,
Review Comment:
good point, we dont route anywhere without string literals, originally I
created functions where one could route_to with non literals but thats not
needed
[simplify Cow
relationships](https://github.com/apache/nifi-minifi-cpp/pull/2246/commits/406ef784af7cf4c0d05e27dc7bf82983b8432b4a)
(not a commit message i ever thought i was gonna write)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
