szaszm commented on a change in pull request #1226:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1226#discussion_r768666904
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -212,6 +212,10 @@ void ProcessSession::transfer(const
std::shared_ptr<core::FlowFile> &flow, Relat
}
void ProcessSession::write(const std::shared_ptr<core::FlowFile> &flow,
OutputStreamCallback *callback) {
+ gsl_ExpectsAudit(_updatedFlowFiles.contains(flow->getUUID())
Review comment:
I would not be against a public member function that can check if a flow
file can be written to. I don't know a good name though. Maybe `bool
canBeWrittenTo(const core::FlowFile&) const noexcept;`? If we did that,
`PyProcessSession` could check that and `write`/`append` could have that as
their precondition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
