szaszm commented on a change in pull request #1226:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1226#discussion_r768640855
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -212,6 +212,10 @@ void ProcessSession::transfer(const
std::shared_ptr<core::FlowFile> &flow, Relat
}
void ProcessSession::write(const std::shared_ptr<core::FlowFile> &flow,
OutputStreamCallback *callback) {
+ gsl_ExpectsAudit(_updatedFlowFiles.contains(flow->getUUID())
Review comment:
I prefer the narrow contract (we can document preconditions to scripting
users, too), but if you decide to have a wide contract, then please use if +
throw or something similar to implement it, not gsl_Expects (which is meant to
declare preconditions).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
