adamdebreceni commented on a change in pull request #1226:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1226#discussion_r768662563
##########
File path: libminifi/src/core/ProcessSession.cpp
##########
@@ -212,6 +212,10 @@ void ProcessSession::transfer(const
std::shared_ptr<core::FlowFile> &flow, Relat
}
void ProcessSession::write(const std::shared_ptr<core::FlowFile> &flow,
OutputStreamCallback *callback) {
+ gsl_ExpectsAudit(_updatedFlowFiles.contains(flow->getUUID())
Review comment:
I prefer having the checks if possible (unless they are too costly and
in the hot path) instead of the "read-the-docs" hands-off strategy, as the
scripting processor is not really used, I'm fine with leaving it as-is, but IMO
it is something we should revisit if need arises
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
