szaszm commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r680818699
##########
File path: extensions/script/CMakeLists.txt
##########
@@ -68,13 +58,10 @@ if (ENABLE_LUA_SCRIPTING)
add_definitions(-DLUA_SUPPORT)
file(GLOB LUA_SOURCES "lua/*.cpp")
- add_library(minifi-lua-extensions STATIC ${LUA_SOURCES})
-
- target_link_libraries(minifi-lua-extensions ${LIBMINIFI})
- target_link_libraries(minifi-lua-extensions ${LUA_LIBRARIES} sol)
- target_link_libraries(minifi-script-extensions minifi-lua-extensions)
+ target_sources(minifi-script-extensions PRIVATE ${LUA_SOURCES})
- target_compile_features(minifi-lua-extensions PUBLIC cxx_std_14)
+ target_link_libraries(minifi-script-extensions ${LUA_LIBRARIES} sol)
+ target_compile_features(minifi-script-extensions PUBLIC cxx_std_14)
Review comment:
Ok, and I just realized that even linking is conditional. Nevermind then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
