adamdebreceni commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r683288063
##########
File path: libminifi/include/core/state/nodes/DeviceInformation.h
##########
@@ -39,6 +37,10 @@
#else
#pragma comment(lib, "iphlpapi.lib")
+#ifndef WIN32_LEAN_AND_MEAN
+#define WIN32_LEAN_AND_MEAN 1
+#endif
Review comment:
~it seems you yourself have already added it in #967~ somebody have
already added it, but did not remove them from source/header files, we should
remove all of them in a separate PR
edit: you just modified the line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
