szaszm commented on a change in pull request #1138:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1138#discussion_r680774954
##########
File path: extensions/script/CMakeLists.txt
##########
@@ -68,13 +58,10 @@ if (ENABLE_LUA_SCRIPTING)
add_definitions(-DLUA_SUPPORT)
file(GLOB LUA_SOURCES "lua/*.cpp")
- add_library(minifi-lua-extensions STATIC ${LUA_SOURCES})
-
- target_link_libraries(minifi-lua-extensions ${LIBMINIFI})
- target_link_libraries(minifi-lua-extensions ${LUA_LIBRARIES} sol)
- target_link_libraries(minifi-script-extensions minifi-lua-extensions)
+ target_sources(minifi-script-extensions PRIVATE ${LUA_SOURCES})
- target_compile_features(minifi-lua-extensions PUBLIC cxx_std_14)
+ target_link_libraries(minifi-script-extensions ${LUA_LIBRARIES} sol)
+ target_compile_features(minifi-script-extensions PUBLIC cxx_std_14)
Review comment:
I can imagine scenarios where a user wants lua scripting, but doesn't
want to install a python interpreter on their embedded system. Or the other way
around. So I don't agree with the separation being "artificial" in the sense of
being unnecessary.
I can accept a new limitation because of this feature, if it's not worth
your time to fix this issue. In this case, please adapt the main CMakeLists.txt
and the bootstrap script to only have one option that toggles scripting support
with both python and lua.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
