hunyadi-dev commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r543388359
##########
File path: extensions/standard-processors/processors/GetTCP.cpp
##########
@@ -148,7 +149,13 @@ void GetTCP::onSchedule(const
std::shared_ptr<core::ProcessContext> &context, co
logger_->log_trace("EOM is defined as %i", endOfMessageByte);
- context->getProperty(ReconnectInterval.getName(), reconnect_interval_);
+ std::string reconnect_interval_str;
+ if (context->getProperty(ReconnectInterval.getName(),
reconnect_interval_str) &&
+ core::Property::getTimeMSFromString(reconnect_interval_str,
reconnect_interval_)) {
+ logger_->log_debug("Reconnect interval is %d ms", reconnect_interval_);
Review comment:
Minor but this might overflow for `uint64_t`:
https://godbolt.org/z/WsTK8W
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
