lordgamez commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r543427100



##########
File path: libminifi/test/persistence-tests/PersistenceTests.cpp
##########
@@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on 
modification", "[TestP1]") {
     ff_repository->start();
     // wait for FlowFileRepository to start and notify the owners of
     // the resurrected FlowFiles
-    std::this_thread::sleep_for(std::chrono::milliseconds{100});
-
+    std::this_thread::sleep_for(std::chrono::milliseconds(100));

Review comment:
       As I checked the RepoTests there isn't anything logged there from the 
FlowFileRepository perspective:
   ```
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::FlowFileRecord logger got sinks from namespace root 
and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::utils::IdGenerator logger got sinks from namespace 
root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::FlowFile logger got sinks from namespace root 
and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::provenance::ProvenanceEventRecord logger got sinks 
from namespace root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::internal::RocksDatabase logger got sinks from 
namespace root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::Properties logger got sinks from namespace root and 
level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] Set 
following pattern on loggers: [%Y-%m-%d %H:%M:%S.%e] [%n] [%l] %v
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
LogTestController logger got sinks from namespace root and level info from 
namespace LogTestController
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::Connectable logger got sinks from namespace 
root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::Repository logger got sinks from namespace 
root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::repository::VolatileRepository<std::__cxx11::basic_string<char,
 std::char_traits<char>, std::allocator<char> > > logger got sinks from 
namespace root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::repository::VolatileContentRepository logger 
got sinks from namespace root and level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::Connection logger got sinks from namespace root and 
level error from namespace root
   [2020-12-15 15:59:02.639] 
[org::apache::nifi::minifi::core::logging::LoggerConfiguration] [debug] 
org::apache::nifi::minifi::core::repository::FlowFileRepository logger got 
sinks from namespace root and level error from namespace root
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to