fgerlits commented on a change in pull request #959:
URL: https://github.com/apache/nifi-minifi-cpp/pull/959#discussion_r543229726
##########
File path: libminifi/test/persistence-tests/PersistenceTests.cpp
##########
@@ -326,11 +335,15 @@ TEST_CASE("Persisted flowFiles are updated on
modification", "[TestP1]") {
ff_repository->start();
// wait for FlowFileRepository to start and notify the owners of
// the resurrected FlowFiles
- std::this_thread::sleep_for(std::chrono::milliseconds{100});
-
+ std::this_thread::sleep_for(std::chrono::milliseconds(100));
Review comment:
Is there a better way to wait for the repository to start, eg. by
checking some atomic variable? This sleep looks like it can be a source of
flakiness, too.
(Same comment on the two similar sleeps in RepoTests.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
