gnodet commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2869970640

   > JUnit 5 is equal, therefore superior to AssertJ.
   > 
   > 
   > 
   > only need to apply: JUnit Jupiter best practices
   > 
   > 
   > 
   > - https://github.com/apache/maven/pull/2320
   > 
   > 
   > 
   > <img width="1525" alt="image" 
src="https://github.com/user-attachments/assets/0cd8121c-ba09-44af-b408-604711e7817b";
 />
   
   I'm actually skeptical.  
   The new ActivationFile().equals(null) actually calls the equals method and 
checks the result, whereas I assume the assertNotEquals or the asserts 
equivalent may bypass the call, just like Objects.equals if one of the 
parameters is null.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to