gnodet commented on code in PR #2307:
URL: https://github.com/apache/maven/pull/2307#discussion_r2083465179


##########
impl/maven-impl/src/test/java/org/apache/maven/impl/AbstractVersionTest.java:
##########
@@ -40,21 +39,21 @@ protected void assertOrder(int expected, String version1, 
String version2) {
         Version v2 = newVersion(version2);
 
         if (expected > 0) {
-            assertEquals(1, Integer.signum(v1.compareTo(v2)), "expected " + v1 
+ " > " + v2);
-            assertEquals(-1, Integer.signum(v2.compareTo(v1)), "expected " + 
v2 + " < " + v1);
-            assertNotEquals(v1, v2, "expected " + v1 + " != " + v2);
-            assertNotEquals(v2, v1, "expected " + v2 + " != " + v1);
+            assertThat(Integer.signum(v1.compareTo(v2))).as("expected " + v1 + 
" > " + v2).isEqualTo(1);
+            assertThat(Integer.signum(v2.compareTo(v1))).as("expected " + v2 + 
" < " + v1).isEqualTo(-1);
+            assertThat(v2).as("expected " + v1 + " != " + v2).isNotEqualTo(v1);

Review Comment:
   Aren't those messages automatically generated by assertJ in case of failures 
?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to