Bukama commented on code in PR #2307:
URL: https://github.com/apache/maven/pull/2307#discussion_r2083465266
##########
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelVersionParserTest.java:
##########
@@ -22,15 +22,14 @@
import org.eclipse.aether.util.version.GenericVersionScheme;
import org.junit.jupiter.api.Test;
-import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNotNull;
+import static org.assertj.core.api.Assertions.assertThat;
class DefaultModelVersionParserTest {
@Test
void parseVersion() {
Version v = new DefaultModelVersionParser(new
GenericVersionScheme()).parseVersion("");
- assertNotNull(v);
- assertEquals("", v.toString());
+ assertThat(v).isNotNull();
+ assertThat(v.toString()).isEqualTo("");
Review Comment:
> Is there any `isEmpty()` assertion ?
If not, you can create custom assertions for AssertJ very easly. I do this
quite a lot at work for custom objects/classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
