gnodet commented on code in PR #2272:
URL: https://github.com/apache/maven/pull/2272#discussion_r2058021561


##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -597,8 +597,8 @@ String replaceCiFriendlyVersion(Map<String, String> 
properties, String version)
                         // extract the key inside ${}
                         String key = matcher.group(1);

Review Comment:
   Yes, though I'm not sure it will completely solve the original problem which 
is to provide the version using a profile.  This may require to use a different 
mechanism, such as default values with the support for `:-` and `:+` already 
provided by the interpolator.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to