gnodet commented on code in PR #2272: URL: https://github.com/apache/maven/pull/2272#discussion_r2057963779
########## impl/maven-core/src/test/resources/projects/pom-parent-version-from-nested-properties/pom.xml: ########## @@ -0,0 +1,14 @@ +<project xmlns="http://maven.apache.org/POM/4.1.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; + xsi:schemaLocation="http://maven.apache.org/POM/4.1.0 http://maven.apache.org/xsd/maven-4.1.0.xsd";> + <modelVersion>4.0.0</modelVersion> Review Comment: Please change this line to 4.1.0. This should make the test fail with: ``` org.apache.maven.project.ProjectBuildingException: 1 problem was - [FATAL] 'version' contains an expression but should be a constant. @ line 7, column 3 for project at .../maven/impl/maven-core/src/test/resources/projects/pom-parent-version-from-nested-properties/pom.xml ``` The reason is that the 4.1.0 model validation enforces the fact that version can be completely resolved. I think we need to use the `org.apache.maven.impl.model.DefaultInterpolator` service as indicated in the TODO above -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
