gnodet commented on code in PR #2272:
URL: https://github.com/apache/maven/pull/2272#discussion_r2057972739
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java:
##########
@@ -597,8 +597,8 @@ String replaceCiFriendlyVersion(Map<String, String>
properties, String version)
// extract the key inside ${}
String key = matcher.group(1);
Review Comment:
Actually the whole method can be replaced easily with:
```
String replaceCiFriendlyVersion(Map<String, String> properties,
String version) {
return version != null ? interpolator.interpolate(version,
properties::get) : null;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
