gnodet commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1142137049
##########
maven-model-builder/src/site/apt/index.apt:
##########
@@ -192,6 +192,10 @@ Maven Model Builder
*----+------+------+
| <<<maven.home>>> | The path to the current Maven home. |
<<<$\{maven.home\}>>> |
*----+------+------+
+| <<<maven.rootdir>>> | the directory containing the root <<<pom.xml>>> file
of a multi module project, in a single module project this is the same as
<<<project.basedir>>> | <<<$\{maven.rootdir\}>>> |
+*----+------+------+
+| <<<maven.topdir>>> | the directory containing the top-level <<<pom.xml>>> in
this reactor build | <<<$\{maven.topdir\}>>> |
+*----+------+------+
Review Comment:
Actually, `topdir` should not be part of any model interpolation, because
it's mainly the current directory and should definitely not have any effect.
This will require an additional parameter to `ModelInterpolator.interpolate()`
or to add it to the `ModelBuildingRequest`.
However, `rootdir` should be part of profile activation along `basedir` imho.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
