michael-o commented on code in PR #1061:
URL: https://github.com/apache/maven/pull/1061#discussion_r1142073069
##########
maven-core/src/main/java/org/apache/maven/execution/MavenExecutionRequest.java:
##########
@@ -91,8 +92,17 @@ public interface MavenExecutionRequest {
// ----------------------------------------------------------------------
// Base directory
+
+ /**
+ * @deprecated use {@link #getTopdir()} instead
Review Comment:
Looks wrong? Should point to the setter.
##########
maven-core/src/main/java/org/apache/maven/execution/MavenSession.java:
##########
@@ -141,10 +142,28 @@ public List<MavenProject> getProjects() {
return projects;
}
+ /**
+ * @deprecated use {@link #getTopdir()}
+ */
+ @Deprecated
public String getExecutionRootDirectory() {
return request.getBaseDirectory();
}
+ /**
+ * @since 4.0
+ */
+ public Path getTopdir() {
+ return request.getTopdir();
+ }
+
+ /**
+ * @since 4.0
Review Comment:
4.0.0
##########
maven-core/src/main/java/org/apache/maven/execution/MavenSession.java:
##########
@@ -141,10 +142,28 @@ public List<MavenProject> getProjects() {
return projects;
}
+ /**
+ * @deprecated use {@link #getTopdir()}
+ */
+ @Deprecated
public String getExecutionRootDirectory() {
return request.getBaseDirectory();
}
+ /**
+ * @since 4.0
Review Comment:
4.0.0
##########
maven-model-builder/src/site/apt/index.apt:
##########
@@ -192,6 +192,10 @@ Maven Model Builder
*----+------+------+
| <<<maven.home>>> | The path to the current Maven home. |
<<<$\{maven.home\}>>> |
*----+------+------+
+| <<<maven.rootdir>>> | the directory containing the root <<<pom.xml>>> file
of a multi module project, in a single module project this is the same as
<<<project.basedir>>> | <<<$\{maven.rootdir\}>>> |
+*----+------+------+
+| <<<maven.topdir>>> | the directory containing the top-level <<<pom.xml>>> in
this reactor build | <<<$\{maven.topdir\}>>> |
+*----+------+------+
Review Comment:
I believe that these properties should not propagate into system properties
permanently, but should be private `_maven.` because `maven.` refers to the
Maven installation here, everything else is `project.` or `session.`. Let's not
repeat that mistake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
