bitflicker64 commented on code in PR #3149:
URL: https://github.com/apache/hugegraph/pull/3149#discussion_r3866731744
##########
docker/docker-compose-3pd-3store-3server.yml:
##########
@@ -187,16 +207,25 @@ services:
<<: *server-common
container_name: hg-server0
hostname: server0
+ environment:
+ <<: *server-env
+ HG_SERVER_REST_URL: http://server0:8080
Review Comment:
Leaving this one open deliberately, since it is the only finding I did not
actually satisfy.
You asked for a configurable advertised address, or for the external client
path to use addresses it can resolve. Neither is possible from the Compose
files: `HG_SERVER_REST_URL` becomes `restserver.url`, which is also the address
the REST server binds, so an externally resolvable value crash-loops the
replica. Splitting bind from advertise needs a Server-side setting.
What shipped is the limitation documented, with external clients pointed at
the published ports instead of PD discovery. Your call whether that is an
acceptable close or whether it should become a Server issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]