bitflicker64 commented on code in PR #3149: URL: https://github.com/apache/hugegraph/pull/3149#discussion_r3839619911
########## docker/docker-compose-3pd-3store-3server.yml: ########## @@ -31,6 +36,8 @@ volumes: # ── Shared service defaults ────────────────────────────────────────── x-pd-common: &pd-common + # Pin a release via HUGEGRAPH_VERSION in docker/.env; unset, the image Review Comment: Fixed in c3115579, and you were right that this belonged here rather than in a follow-up. Both halves of your suggestion are in: all four images now use `pull_policy: always`, so a stale cached `latest` is refreshed, and Server readiness no longer probes public `/versions`. It requires an unauthenticated graph request to return 401 and an authenticated one to return 200. An image that ignores `PASSWORD` never reports healthy, so `up -d --wait` fails instead of handing back an open cluster. Verified on a clean Docker host: 9/9 healthy against `latest` (1.7.0), 401/200 on all three replicas, wrong password 401. ########## docker/docker-compose-3pd-3store-3server.yml: ########## @@ -17,9 +17,14 @@ name: hugegraph-3x3 +# The cluster network is shared with the Hubble add-on +# (docker-compose-hubble.yml), so it is external and must exist first: +# docker network create hugegraph-net +# Set HUGEGRAPH_NETWORK to use a differently named network. networks: hg-net: - driver: bridge + external: true Review Comment: Fixed in c3115579. PD, Store, and Server host ports now bind to `127.0.0.1` by default, so the unauthenticated control plane is not reachable from outside the host. `HUGEGRAPH_CONTROL_PLANE_HOST` and `HUGEGRAPH_SERVER_PUBLISH_HOST` widen them, and the README says to do that only behind a network ACL or TLS. I had asked to defer this as a quickstart redesign. It was not one: the services already talk over `hugegraph-net`, so nothing needed those host bindings. Verified live: `ss -ltn` shows `127.0.0.1:8080`, `127.0.0.1:8500`, `127.0.0.1:8620`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
