bitflicker64 commented on PR #3149: URL: https://github.com/apache/hugegraph/pull/3149#issuecomment-5431142330
@imbajin one open question before this is mergeable, on the PD-registered Server addresses. The inline thread is marked outdated (the lines it pointed at are gone), so raising it here where it is visible: https://github.com/apache/hugegraph/pull/3149#discussion_r3770576277 Your ask was a configurable advertised address, or an external client path that resolves. I could not do either from Compose: `HG_SERVER_REST_URL` becomes `restserver.url`, which is also the address the REST server binds, so an externally reachable value crash-loops the replica on `java.net.BindException: Cannot assign requested address`. I confirmed that by running it. Splitting bind from advertise needs a Server-side setting. So, which way do you want it closed? **A.** Accept it as a documented limitation. External clients use the published Server ports; PD discovery stays correct for anything on `hugegraph-net`, which is the Hubble case this add-on exists for. **B.** I open a Server issue for a real advertised-address option and link it here. I lean A for this PR, since B is a Server change that would hold up the add-on. Happy to file B regardless if you want it tracked. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
