imbajin commented on code in PR #3159:
URL: https://github.com/apache/hugegraph/pull/3159#discussion_r3804200777


##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java:
##########
@@ -2461,4 +2518,36 @@ public String toString() {
             return this.origin.toString();
         }
     }
+
+    private static Set<HugePermission> traversalPermissions(
+                                       Traversal.Admin<?, ?> traversal) {
+        Set<HugePermission> permissions = EnumSet.noneOf(HugePermission.class);
+        collectTraversalPermissions(traversal, permissions);
+        return permissions;
+    }
+
+    private static void collectTraversalPermissions(
+                        Traversal.Admin<?, ?> traversal,
+                        Set<HugePermission> permissions) {
+        for (Step<?, ?> step : traversal.getSteps()) {
+            if (step instanceof AddVertexStartStep ||

Review Comment:
   Follow-up hardening in 17615dc0 scopes compatibility matching to the exact 
TinkerPop 
`org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeVertexStep` / 
`MergeEdgeStep` class names while still walking superclasses for provider 
implementations. An unrelated step with the same simple name is now explicitly 
verified as non-WRITE; exact 3.7 class-name compatibility and recursive child 
traversal coverage remain. `HugeGraphAuthProxyTest`: 25 tests passed; targeted 
API/test Checkstyle also passed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to