imbajin commented on code in PR #3159:
URL: https://github.com/apache/hugegraph/pull/3159#discussion_r3804135259
##########
hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/auth/HugeGraphAuthProxy.java:
##########
@@ -2461,4 +2518,36 @@ public String toString() {
return this.origin.toString();
}
}
+
+ private static Set<HugePermission> traversalPermissions(
+ Traversal.Admin<?, ?> traversal) {
+ Set<HugePermission> permissions = EnumSet.noneOf(HugePermission.class);
+ collectTraversalPermissions(traversal, permissions);
+ return permissions;
+ }
+
+ private static void collectTraversalPermissions(
+ Traversal.Admin<?, ?> traversal,
+ Set<HugePermission> permissions) {
+ for (Step<?, ?> step : traversal.getSteps()) {
+ if (step instanceof AddVertexStartStep ||
Review Comment:
Fixed in 8c69441c. `MergeVertexStep` and `MergeEdgeStep` are now classified
as WRITE steps (including provider subclasses via class-hierarchy matching),
while the existing `TraversalParent` walk recursively inspects all local/global
children. The class-name guard is intentional because this branch still
compiles against TinkerPop 3.5.1, so importing 3.7.x merge classes would force
an unrelated dependency upgrade. Added strategy-level execute-only regressions
for vertex/edge create and onMatch shapes plus a merge-child recursion case.
Verified with `mvn -ntp -P unit-test -pl hugegraph-server/hugegraph-test -am
-Dtest=HugeGraphAuthProxyTest -Dsurefire.failIfNoSpecifiedTests=false test` (27
tests, all passing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
