imbajin commented on PR #3159:
URL: https://github.com/apache/hugegraph/pull/3159#issuecomment-5311316617

   ### Why this branch contains PD Raft changes
   
   The PD change in `3d9d9544` is independent of the REST API `0.72` bump. It 
was identified while preparing the real 3-PD distributed matrix, where PD peers 
use stable hostnames but container/Pod IPs may change after restart or 
membership updates.
   
   Before:
   
   - `IpAuthHandler` resolved peer hostnames only at startup or an explicit 
peer-list update;
   - the same hostname resolving to a new Pod IP could leave the Raft allowlist 
stale and reject a valid peer;
   - peer changes could update Raft membership without a reliably synchronized 
allowlist;
   - a fully unresolved/empty result followed the old allow-all path;
   - resolver, singleton, RPC-server and failed-start cleanup were incomplete.
   
   After:
   
   - configured/runtime peer addresses are normalized and bounded before use;
   - DNS resolution has timeout, concurrency and stale-entry limits, with 
background refresh;
   - successful membership changes refresh the active allowlist;
   - startup/shutdown failures clean the resolver, handler and RPC resources;
   - unit, service-update and Raft integration tests cover these boundaries.
   
   Most of the apparent size is defensive behavior and tests: this commit is 
`+1375/-226`, including about 700 added test lines and relocation/expansion of 
the old `IpAuthHandlerTest`.
   
   Scope note: this is not required to distinguish API `0.71` from `0.72`, nor 
by the Hubble permission capability itself. It should be reviewed as a 
standalone PD reliability/security change (and preferably split from the 
API-version PR). Passing tests do not replace the pending final 3+3+3 runtime 
validation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to