[ https://issues.apache.org/jira/browse/HIVE-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16278425#comment-16278425 ]
Peter Vary commented on HIVE-18222: ----------------------------------- [~kgyrtkirk]: Could you please check that yetus runs with the new checkstyle? I do not think there should be any problems, but a manual run should be easy to do. Also: Is it ok if we change the max line length without a discuss thread? I am all for it, but did not want to change it myself before :) > Update checkstyle rules to be less peeky > ---------------------------------------- > > Key: HIVE-18222 > URL: https://issues.apache.org/jira/browse/HIVE-18222 > Project: Hive > Issue Type: Sub-task > Components: Tests > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Attachments: HIVE-18222.01.patch > > > there are a few issues with the current checkstyle.xml > as long as the new checks are coming back red all the time; people will start > to ignore these checks...so I think, it would be better to make the checks > less strict... > * set max linelength to 140; it looks like a more natural limit - because > there are classnames which are eating up line space pretty quickly... like: > {{PrimitiveObjectInspector}} :) > * make checkstyle.xml easily importable into ide (use {{config_loc}} instead > {{basedir}}) > * suppress generated vectorized class errors -- This message was sent by Atlassian JIRA (v6.4.14#64029)