[ https://issues.apache.org/jira/browse/HIVE-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281175#comment-16281175 ]
Hive QA commented on HIVE-18222: -------------------------------- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || || || || || {color:brown} Prechecks {color} || | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | || || || || {color:brown} master Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 1m 14s{color} | {color:blue} Maven dependency ordering for branch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 4m 56s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 45s{color} | {color:green} master passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 38s{color} | {color:green} master passed {color} | || || || || {color:brown} Patch Compile Tests {color} || | {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 20s{color} | {color:blue} Maven dependency ordering for patch {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 5m 28s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 4m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 4m 51s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} xml {color} | {color:green} 0m 8s{color} | {color:green} The patch has no ill-formed XML file. {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 6m 8s{color} | {color:green} the patch passed {color} | || || || || {color:brown} Other Tests {color} || | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 12s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 35m 7s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Optional Tests | asflicense xml javac javadoc compile | | uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux | | Build tool | maven | | Personality | /data/hiveptest/working/yetus/dev-support/hive-personality.sh | | git revision | master / 4d2dc35 | | Default Java | 1.8.0_111 | | modules | C: storage-api standalone-metastore . U: . | | Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-8137/yetus.txt | | Powered by | Apache Yetus http://yetus.apache.org | This message was automatically generated. > Update checkstyle rules to be less peeky > ---------------------------------------- > > Key: HIVE-18222 > URL: https://issues.apache.org/jira/browse/HIVE-18222 > Project: Hive > Issue Type: Sub-task > Components: Tests > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Attachments: HIVE-18222.01.patch > > > there are a few issues with the current checkstyle.xml > as long as the new checks are coming back red all the time; people will start > to ignore these checks...so I think, it would be better to make the checks > less strict... > * set max linelength to 140; it looks like a more natural limit - because > there are classnames which are eating up line space pretty quickly... like: > {{PrimitiveObjectInspector}} :) > * make checkstyle.xml easily importable into ide (use {{config_loc}} instead > {{basedir}}) > * suppress generated vectorized class errors -- This message was sent by Atlassian JIRA (v6.4.14#64029)