[ https://issues.apache.org/jira/browse/HIVE-18222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281194#comment-16281194 ]
Hive QA commented on HIVE-18222: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12900645/HIVE-18222.01.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 4 failed/errored test(s), 11512 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[hybridgrace_hashjoin_2] (batchId=157) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[insert_values_orig_table_use_metadata] (batchId=165) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[sysdb] (batchId=160) org.apache.hadoop.hive.ql.parse.TestReplicationScenarios.testConstraints (batchId=226) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/8137/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/8137/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-8137/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.YetusPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12900645 - PreCommit-HIVE-Build > Update checkstyle rules to be less peeky > ---------------------------------------- > > Key: HIVE-18222 > URL: https://issues.apache.org/jira/browse/HIVE-18222 > Project: Hive > Issue Type: Sub-task > Components: Tests > Reporter: Zoltan Haindrich > Assignee: Zoltan Haindrich > Attachments: HIVE-18222.01.patch > > > there are a few issues with the current checkstyle.xml > as long as the new checks are coming back red all the time; people will start > to ignore these checks...so I think, it would be better to make the checks > less strict... > * set max linelength to 140; it looks like a more natural limit - because > there are classnames which are eating up line space pretty quickly... like: > {{PrimitiveObjectInspector}} :) > * make checkstyle.xml easily importable into ide (use {{config_loc}} instead > {{basedir}}) > * suppress generated vectorized class errors -- This message was sent by Atlassian JIRA (v6.4.14#64029)