[ https://issues.apache.org/jira/browse/HIVE-12274?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15885137#comment-15885137 ]
Hive QA commented on HIVE-12274: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12854811/HIVE-12274.2.patch {color:red}ERROR:{color} -1 due to no test(s) being added or modified. {color:red}ERROR:{color} -1 due to 84 failed/errored test(s), 10266 tests executed *Failed tests:* {noformat} org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query12] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query13] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query14] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query15] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query16] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query17] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query18] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query19] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query1] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query20] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query21] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query22] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query23] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query25] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query26] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query27] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query28] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query29] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query30] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query31] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query32] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query33] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query34] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query36] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query37] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query38] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query39] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query3] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query40] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query42] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query43] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query46] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query48] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query50] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query51] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query52] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query54] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query55] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query56] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query58] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query5] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query60] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query64] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query65] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query66] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query67] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query68] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query69] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query6] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query70] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query71] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query72] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query73] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query75] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query76] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query79] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query7] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query80] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query81] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query82] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query83] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query84] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query85] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query86] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query87] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query88] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query89] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query8] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query90] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query91] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query92] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query93] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query94] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query95] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query96] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query97] (batchId=223) org.apache.hadoop.hive.cli.TestPerfCliDriver.testCliDriver[query98] (batchId=223) org.apache.hadoop.hive.metastore.TestEmbeddedHiveMetaStore.testTableFilter (batchId=194) org.apache.hadoop.hive.metastore.TestRemoteHiveMetaStore.testTableFilter (batchId=197) org.apache.hadoop.hive.metastore.TestSetUGIOnBothClientServer.testTableFilter (batchId=193) org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyClient.testTableFilter (batchId=191) org.apache.hadoop.hive.metastore.TestSetUGIOnOnlyServer.testTableFilter (batchId=202) org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade (batchId=211) org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure (batchId=170) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/3802/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/3802/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-3802/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 84 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12854811 - PreCommit-HIVE-Build > Increase width of columns used for general configuration in the metastore. > -------------------------------------------------------------------------- > > Key: HIVE-12274 > URL: https://issues.apache.org/jira/browse/HIVE-12274 > Project: Hive > Issue Type: Improvement > Components: Metastore > Affects Versions: 2.0.0 > Reporter: Elliot West > Assignee: Naveen Gangam > Labels: metastore > Attachments: HIVE-12274.2.patch, HIVE-12274.example.ddl.hql, > HIVE-12274.patch, HIVE-12274.patch, HIVE-12274.patch > > > h2. Overview > This issue is very similar in principle to HIVE-1364. We are hitting a limit > when processing JSON data that has a large nested schema. The struct > definition is truncated when inserted into the metastore database column > {{COLUMNS_V2.YPE_NAME}} as it is greater than 4000 characters in length. > Given that the purpose of these columns is to hold very loosely defined > configuration values it seems rather limiting to impose such a relatively low > length bound. One can imagine that valid use cases will arise where > reasonable parameter/property values exceed the current limit. > h2. Context > These limitations were in by the [patch > attributed|https://github.com/apache/hive/commit/c21a526b0a752df2a51d20a2729cc8493c228799] > to HIVE-1364 which mentions the _"max length on Oracle 9i/10g/11g"_ as the > reason. However, nowadays the limit can be increased because: > * Oracle DB's {{varchar2}} supports 32767 bytes now, by setting the > configuration parameter {{MAX_STRING_SIZE}} to {{EXTENDED}}. > ([source|http://docs.oracle.com/database/121/SQLRF/sql_elements001.htm#SQLRF55623]) > * Postgres supports a max of 1GB for {{character}} datatype. > ([source|http://www.postgresql.org/docs/8.3/static/datatype-character.html]) > * MySQL can support upto 65535 bytes for the entire row. So long as the > {{PARAM_KEY}} value + {{PARAM_VALUE}} is less than 65535, we should be good. > ([source|http://dev.mysql.com/doc/refman/5.0/en/char.html]) > * SQL Server's {{varchar}} max length is 8000 and can go beyond using > "varchar(max)" with the same limitation as MySQL being 65535 bytes for the > entire row. ([source|http://dev.mysql.com/doc/refman/5.0/en/char.html]) > * Derby's {{varchar}} can be upto 32672 bytes. > ([source|https://db.apache.org/derby/docs/10.7/ref/rrefsqlj41207.html]) > h2. Proposal > Can these columns not use CLOB-like types as for example as used by > {{TBLS.VIEW_EXPANDED_TEXT}}? It would seem that suitable type equivalents > exist for all targeted database platforms: > * MySQL: {{mediumtext}} > * Postgres: {{text}} > * Oracle: {{CLOB}} > * Derby: {{LONG VARCHAR}} > I'd suggest that the candidates for type change are: > * {{COLUMNS_V2.TYPE_NAME}} > * {{TABLE_PARAMS.PARAM_VALUE}} > * {{SERDE_PARAMS.PARAM_VALUE}} > * {{SD_PARAMS.PARAM_VALUE}} > After updating the maximum length the metastore database needs to be > configured and restarted with the new settings. Altering {{MAX_STRING_SIZE}} > will update database objects and possibly invalidate them, as follows: > * Tables with virtual columns will be updated with new data type metadata for > virtual columns of {{VARCHAR2(4000)}}, 4000-byte {{NVARCHAR2}}, or > {{RAW(2000)}} type. > * Functional indexes will become unusable if a change to their associated > virtual columns causes the index key to exceed index key length limits. > Attempts to rebuild such indexes will fail with {{ORA-01450: maximum key > length exceeded}}. > * Views will be invalidated if they contain {{VARCHAR2(4000)}}, 4000-byte > {{NVARCHAR2}}, or {{RAW(2000)}} typed expression columns. > * Materialized views will be updated with new metadata {{VARCHAR2(4000)}}, > 4000-byte {{NVARCHAR2}}, and {{RAW(2000)}} typed expression columns > * So the limitation could be raised to 32672 bytes, with the caveat that > MySQL and SQL Server limit the row length to 65535 bytes, so that should also > be validated to provide consistency. > Finally, will this limitation persist in the work resulting from HIVE-9452? -- This message was sent by Atlassian JIRA (v6.3.15#6346)