[ https://issues.apache.org/jira/browse/HIVE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15786162#comment-15786162 ]
Hive QA commented on HIVE-15518: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12845096/HIVE-15518.4.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 9 failed/errored test(s), 10869 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=233) TestMiniLlapLocalCliDriver - did not produce a TEST-*.xml file (likely timed out) (batchId=144) [vectorized_rcfile_columnar.q,vector_elt.q,explainuser_1.q,multi_insert.q,tez_dml.q,vector_bround.q,schema_evol_orc_acid_table.q,vector_when_case_null.q,orc_ppd_schema_evol_1b.q,vector_join30.q,vectorization_11.q,cte_3.q,update_tmp_table.q,vector_decimal_cast.q,groupby_grouping_id2.q,vector_decimal_round.q,tez_smb_empty.q,orc_merge6.q,vector_char_mapjoin1.q,vector_decimal_trailing.q,cte_5.q,tez_union.q,vector_decimal_2.q,columnStatsUpdateForStatsOptimizer_1.q,vector_outer_join3.q,schema_evol_text_vec_part_all_complex.q,tez_dynpart_hashjoin_2.q,auto_sortmerge_join_12.q,offset_limit.q,tez_union_multiinsert.q] org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=134) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=135) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[offset_limit_ppd_optimizer] (batchId=150) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_1] (batchId=92) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=93) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_4] (batchId=93) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=92) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2747/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2747/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2747/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 9 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12845096 - PreCommit-HIVE-Build > Refactoring rows and range related classes to put the window type on Window > --------------------------------------------------------------------------- > > Key: HIVE-15518 > URL: https://issues.apache.org/jira/browse/HIVE-15518 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing > Reporter: Aihua Xu > Assignee: Aihua Xu > Priority: Minor > Attachments: HIVE-15518.1.patch, HIVE-15518.2.patch, > HIVE-15518.3.patch, HIVE-15518.4.patch > > > {noformat} > /* > * - A Window Frame that has only the /start/boundary, then it is > interpreted as: > BETWEEN <start boundary> AND CURRENT ROW > * - A Window Specification with an Order Specification and no Window > * Frame is interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW > * - A Window Specification with no Order and no Window Frame is > interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING > */ > {noformat} > The comments in WindowSpec above doesn't really match what it's claimed to > do. Correct the comment to reduce the confusion. > Also currently the window type is specified on each BoundarySpec but makes > sense to put the type (rows or range) for each window. -- This message was sent by Atlassian JIRA (v6.3.4#6332)