[ https://issues.apache.org/jira/browse/HIVE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15784059#comment-15784059 ]
Hive QA commented on HIVE-15518: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12844991/HIVE-15518.2.patch {color:green}SUCCESS:{color} +1 due to 1 test(s) being added or modified. {color:red}ERROR:{color} -1 due to 10 failed/errored test(s), 10899 tests executed *Failed tests:* {noformat} TestDerbyConnector - did not produce a TEST-*.xml file (likely timed out) (batchId=233) org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver[windowing_range_multiorder] (batchId=6) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_basic] (batchId=134) org.apache.hadoop.hive.cli.TestMiniLlapCliDriver.testCliDriver[orc_ppd_schema_evol_3a] (batchId=135) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[ptf] (batchId=140) org.apache.hadoop.hive.cli.TestMiniLlapLocalCliDriver.testCliDriver[vectorized_ptf] (batchId=149) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_2] (batchId=93) org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver[explainanalyze_5] (batchId=92) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[ptf] (batchId=101) org.apache.hadoop.hive.cli.TestSparkCliDriver.testCliDriver[vectorized_ptf] (batchId=121) {noformat} Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2743/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2743/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2743/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 10 tests failed {noformat} This message is automatically generated. ATTACHMENT ID: 12844991 - PreCommit-HIVE-Build > Refactoring rows and range related classes to put the window type on Window > --------------------------------------------------------------------------- > > Key: HIVE-15518 > URL: https://issues.apache.org/jira/browse/HIVE-15518 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing > Reporter: Aihua Xu > Assignee: Aihua Xu > Priority: Minor > Attachments: HIVE-15518.1.patch, HIVE-15518.2.patch > > > {noformat} > /* > * - A Window Frame that has only the /start/boundary, then it is > interpreted as: > BETWEEN <start boundary> AND CURRENT ROW > * - A Window Specification with an Order Specification and no Window > * Frame is interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW > * - A Window Specification with no Order and no Window Frame is > interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING > */ > {noformat} > The comments in WindowSpec above doesn't really match what it's claimed to > do. Correct the comment to reduce the confusion. > Also currently the window type is specified on each BoundarySpec but makes > sense to put the type (rows or range) for each window. -- This message was sent by Atlassian JIRA (v6.3.4#6332)