[ https://issues.apache.org/jira/browse/HIVE-15518?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15782980#comment-15782980 ]
Hive QA commented on HIVE-15518: -------------------------------- Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12844933/HIVE-15518.1.patch {color:red}ERROR:{color} -1 due to build exiting with an error Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/2737/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/2737/console Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-2737/ Messages: {noformat} Executing org.apache.hive.ptest.execution.TestCheckPhase Executing org.apache.hive.ptest.execution.PrepPhase Tests exited with: NonZeroExitCodeException Command 'bash /data/hiveptest/working/scratch/source-prep.sh' failed with exit status 1 and output '+ date '+%Y-%m-%d %T.%3N' 2016-12-28 14:21:39.158 + [[ -n /usr/lib/jvm/java-8-openjdk-amd64 ]] + export JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64 + export PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + PATH=/usr/lib/jvm/java-8-openjdk-amd64/bin/:/usr/local/bin:/usr/bin:/bin:/usr/local/games:/usr/games + export 'ANT_OPTS=-Xmx1g -XX:MaxPermSize=256m ' + ANT_OPTS='-Xmx1g -XX:MaxPermSize=256m ' + export 'MAVEN_OPTS=-Xmx1g ' + MAVEN_OPTS='-Xmx1g ' + cd /data/hiveptest/working/ + tee /data/hiveptest/logs/PreCommit-HIVE-Build-2737/source-prep.txt + [[ false == \t\r\u\e ]] + mkdir -p maven ivy + [[ git = \s\v\n ]] + [[ git = \g\i\t ]] + [[ -z master ]] + [[ -d apache-github-source-source ]] + [[ ! -d apache-github-source-source/.git ]] + [[ ! -d apache-github-source-source ]] + date '+%Y-%m-%d %T.%3N' 2016-12-28 14:21:39.161 + cd apache-github-source-source + git fetch origin + git reset --hard HEAD HEAD is now at b558d49 HIVE-15448: ChangeManager (Daniel Dai, reviewed by Thejas Nair) + git clean -f -d Removing ql/src/test/queries/clientpositive/mapjoin3.q Removing ql/src/test/results/clientpositive/llap/mapjoin3.q.out Removing ql/src/test/results/clientpositive/mapjoin3.q.out + git checkout master Already on 'master' Your branch is up-to-date with 'origin/master'. + git reset --hard origin/master HEAD is now at b558d49 HIVE-15448: ChangeManager (Daniel Dai, reviewed by Thejas Nair) + git merge --ff-only origin/master Already up-to-date. + date '+%Y-%m-%d %T.%3N' 2016-12-28 14:21:40.121 + patchCommandPath=/data/hiveptest/working/scratch/smart-apply-patch.sh + patchFilePath=/data/hiveptest/working/scratch/build.patch + [[ -f /data/hiveptest/working/scratch/build.patch ]] + chmod +x /data/hiveptest/working/scratch/smart-apply-patch.sh + /data/hiveptest/working/scratch/smart-apply-patch.sh /data/hiveptest/working/scratch/build.patch Going to apply patch with: patch -p1 patching file ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ExprNodeConverter.java patching file ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java patching file ql/src/java/org/apache/hadoop/hive/ql/parse/PTFTranslator.java patching file ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java patching file ql/src/java/org/apache/hadoop/hive/ql/parse/WindowingSpec.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/PTFDeserializer.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/BoundaryDef.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/CurrentRowDef.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/RangeBoundaryDef.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/ValueBoundaryDef.java patching file ql/src/java/org/apache/hadoop/hive/ql/plan/ptf/WindowFrameDef.java patching file ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java patching file ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java patching file ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java + [[ maven == \m\a\v\e\n ]] + rm -rf /data/hiveptest/working/maven/org/apache/hive + mvn -B clean install -DskipTests -T 4 -q -Dmaven.repo.local=/data/hiveptest/working/maven ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/metastore/target/generated-sources/antlr3/org/apache/hadoop/hive/metastore/parser/FilterParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/metastore/src/java/org/apache/hadoop/hive/metastore/parser/Filter.g org/apache/hadoop/hive/metastore/parser/Filter.g DataNucleus Enhancer (version 4.1.6) for API "JDO" DataNucleus Enhancer : Classpath >> /usr/share/maven/boot/plexus-classworlds-2.x.jar ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDatabase ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFieldSchema ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MType ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTable ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MConstraint ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MSerDeInfo ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MOrder ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MColumnDescriptor ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStringList ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MStorageDescriptor ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartition ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MIndex ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRole ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MRoleMap ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MGlobalPrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDBPrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTablePrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartitionPrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTableColumnPrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartitionColumnPrivilege ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartitionEvent ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MMasterKey ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MDelegationToken ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MTableColumnStatistics ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MPartitionColumnStatistics ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MVersionTable ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MResourceUri ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MFunction ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MNotificationLog ENHANCED (Persistable) : org.apache.hadoop.hive.metastore.model.MNotificationNextId DataNucleus Enhancer completed with success for 30 classes. Timings : input=180 ms, enhance=185 ms, total=365 ms. Consult the log for full details ANTLR Parser Generator Version 3.5.2 Output file /data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveLexer.java does not exist: must build /data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g org/apache/hadoop/hive/ql/parse/HiveLexer.g Output file /data/hiveptest/working/apache-github-source-source/ql/target/generated-sources/antlr3/org/apache/hadoop/hive/ql/parse/HiveParser.java does not exist: must build /data/hiveptest/working/apache-github-source-source/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g org/apache/hadoop/hive/ql/parse/HiveParser.g Generating vector expression code Generating vector expression test code [ERROR] COMPILATION ERROR : [ERROR] /data/hiveptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java:[54,15] constructor BoundaryDef in class org.apache.hadoop.hive.ql.plan.ptf.BoundaryDef cannot be applied to given types; required: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction,int found: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction reason: actual and formal argument lists differ in length [ERROR] /data/hiveptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java:[60,13] constructor BoundaryDef in class org.apache.hadoop.hive.ql.plan.ptf.BoundaryDef cannot be applied to given types; required: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction,int found: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction reason: actual and formal argument lists differ in length [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.1:testCompile (default-testCompile) on project hive-exec: Compilation failure: Compilation failure: [ERROR] /data/hiveptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java:[54,15] constructor BoundaryDef in class org.apache.hadoop.hive.ql.plan.ptf.BoundaryDef cannot be applied to given types; [ERROR] required: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction,int [ERROR] found: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction [ERROR] reason: actual and formal argument lists differ in length [ERROR] /data/hiveptest/working/apache-github-source-source/ql/src/test/org/apache/hadoop/hive/ql/udaf/TestStreamingSum.java:[60,13] constructor BoundaryDef in class org.apache.hadoop.hive.ql.plan.ptf.BoundaryDef cannot be applied to given types; [ERROR] required: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction,int [ERROR] found: org.apache.hadoop.hive.ql.parse.WindowingSpec.Direction [ERROR] reason: actual and formal argument lists differ in length [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <goals> -rf :hive-exec + exit 1 ' {noformat} This message is automatically generated. ATTACHMENT ID: 12844933 - PreCommit-HIVE-Build > Refactoring rows and range related classes to put the window type on Window > --------------------------------------------------------------------------- > > Key: HIVE-15518 > URL: https://issues.apache.org/jira/browse/HIVE-15518 > Project: Hive > Issue Type: Sub-task > Components: PTF-Windowing > Reporter: Aihua Xu > Assignee: Aihua Xu > Priority: Minor > Attachments: HIVE-15518.1.patch > > > {noformat} > /* > * - A Window Frame that has only the /start/boundary, then it is > interpreted as: > BETWEEN <start boundary> AND CURRENT ROW > * - A Window Specification with an Order Specification and no Window > * Frame is interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW > * - A Window Specification with no Order and no Window Frame is > interpreted as: > ROW BETWEEN UNBOUNDED PRECEDING AND UNBOUNDED FOLLOWING > */ > {noformat} > The comments in WindowSpec above doesn't really match what it's claimed to > do. Correct the comment to reduce the confusion. > Also currently the window type is specified on each BoundarySpec but makes > sense to put the type (rows or range) for each window. -- This message was sent by Atlassian JIRA (v6.3.4#6332)