[ 
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837862
 ]

ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jan/23 10:08
            Start Date: 09/Jan/23 10:08
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064465388


##########
ql/src/java/org/apache/hadoop/hive/ql/util/HiveStrictManagedMigration.java:
##########
@@ -1450,7 +1446,9 @@ private TxnCtx generateTxnCtxForAlter(
           result = new TxnCtx(writeId, validWriteIds, txnId);
         } finally {
           if (result == null) {
-            msc.abortTxns(Lists.newArrayList(txnId));
+            AbortTxnsRequest abortTxnsRequest = new 
AbortTxnsRequest(Lists.newArrayList(txnId));
+            
abortTxnsRequest.setErrorCode(TxnErrorMsg.ABORT_MIGRATION_TXN.getErrorCode());
+            msc.abortTxns(abortTxnsRequest);

Review Comment:
   there is a method to abort a single txn, why can't you use it?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 837862)
    Time Spent: 8h 50m  (was: 8h 40m)

> Add aborted reason to transaction information.
> ----------------------------------------------
>
>                 Key: HIVE-11495
>                 URL: https://issues.apache.org/jira/browse/HIVE-11495
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore, Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Sourabh Badhya
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 8h 50m
>  Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn 
> (since HIVE-13395)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to