[ 
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837864&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837864
 ]

ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jan/23 10:10
            Start Date: 09/Jan/23 10:10
    Worklog Time Spent: 10m 
      Work Description: deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064467843


##########
standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/hive_metastore.proto:
##########
@@ -1966,13 +1966,15 @@ message AbortTxnRequest {
   int64 txnid = 1;
   string repl_policy = 2;
   TxnType txn_type = 3;
+  int64 errorCode = 4;

Review Comment:
   should be optional, for backward compatibility



##########
standalone-metastore/metastore-common/src/main/protobuf/org/apache/hadoop/hive/metastore/hive_metastore.proto:
##########
@@ -1966,13 +1966,15 @@ message AbortTxnRequest {
   int64 txnid = 1;
   string repl_policy = 2;
   TxnType txn_type = 3;
+  int64 errorCode = 4;
 }
 
 message AbortTxnResponse {
 }
 
 message AbortTxnsRequest {
   repeated int64 txn_ids = 1;
+  int64 errorCode = 2;

Review Comment:
   should be optional, for backward compatibility





Issue Time Tracking
-------------------

    Worklog Id:     (was: 837864)
    Time Spent: 9h  (was: 8h 50m)

> Add aborted reason to transaction information.
> ----------------------------------------------
>
>                 Key: HIVE-11495
>                 URL: https://issues.apache.org/jira/browse/HIVE-11495
>             Project: Hive
>          Issue Type: Improvement
>          Components: Metastore, Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Sourabh Badhya
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 9h
>  Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn 
> (since HIVE-13395)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to