[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837832&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837832
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/23 08:58
Start Date: 09/Jan/23 08:58
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064401527
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5144,6 +5159,7 @@ private int abortTxns(Connection dbConn, List<Long>
txnids, boolean checkHeartbe
if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_ABORTED_TXNS).inc(txnids.size());
}
+ LOG.info("Txns are aborted successfully due to : {}", errorMsg);
Review Comment:
For `performTimeOuts()`
Removed this log - `LOG.info("Aborted the following transactions due to
timeout: {}", batchToAbort.toString());`
For `commitTxn()`
Changed this log to include only the committed transaction details and not
the ones that are going to be aborted.
Added aborted transaction IDs in the generic log.
Issue Time Tracking
-------------------
Worklog Id: (was: 837832)
Time Spent: 7h 10m (was: 7h)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h 10m
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
