[
https://issues.apache.org/jira/browse/HIVE-11495?focusedWorklogId=837831&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-837831
]
ASF GitHub Bot logged work on HIVE-11495:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jan/23 08:55
Start Date: 09/Jan/23 08:55
Worklog Time Spent: 10m
Work Description: SourabhBadhya commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1064398828
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -1087,6 +1096,10 @@ public void abortTxn(AbortTxnRequest rqst) throws
NoSuchTxnException, MetaExcept
@RetrySemantics.Idempotent
public void abortTxns(AbortTxnsRequest rqst) throws MetaException {
List<Long> txnIds = rqst.getTxn_ids();
+ TxnErrorMsg txnErrorMsg = TxnErrorMsg.NONE;
Review Comment:
Changed default values in all places to `TxnErrorMsg.NONE`. Done.
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5088,12 +5102,13 @@ private int abortTxns(Connection dbConn, List<Long>
txnids,
* @throws SQLException
*/
private int abortTxns(Connection dbConn, List<Long> txnids, boolean
checkHeartbeat,
- boolean skipCount, boolean isReplReplayed)
+ boolean skipCount, boolean isReplReplayed, TxnErrorMsg
errorMsg)
throws SQLException, MetaException {
Statement stmt = null;
if (txnids.isEmpty()) {
return 0;
}
+ LOG.info("Trying to abort txns due to : {}", errorMsg);
Review Comment:
Done.
Issue Time Tracking
-------------------
Worklog Id: (was: 837831)
Time Spent: 7h (was: 6h 50m)
> Add aborted reason to transaction information.
> ----------------------------------------------
>
> Key: HIVE-11495
> URL: https://issues.apache.org/jira/browse/HIVE-11495
> Project: Hive
> Issue Type: Improvement
> Components: Metastore, Transactions
> Affects Versions: 1.0.0
> Reporter: Eugene Koifman
> Assignee: Sourabh Badhya
> Priority: Major
> Labels: pull-request-available
> Time Spent: 7h
> Remaining Estimate: 0h
>
> Add logging messages mentioning the reason to abort the transaction.
> Another reason: Commit can fail due to a conflicting write from another txn
> (since HIVE-13395)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
