[
https://issues.apache.org/jira/browse/HIVE-24918?focusedWorklogId=626368&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-626368
]
ASF GitHub Bot logged work on HIVE-24918:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jul/21 23:54
Start Date: 21/Jul/21 23:54
Worklog Time Spent: 10m
Work Description: hmangla98 commented on a change in pull request #2121:
URL: https://github.com/apache/hive/pull/2121#discussion_r674418314
##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplDumpTask.java
##########
@@ -424,11 +518,13 @@ private boolean validDump(Path dumpDir) throws
IOException {
return false;
}
- private boolean shouldDump(Path previousDumpPath) throws IOException {
+ private boolean shouldDump(Path previousDumpPath, boolean
isPrevDumpFailoverReady) throws IOException {
//If no previous dump means bootstrap. So return true as there was no
//previous dump to load
if (previousDumpPath == null) {
return true;
+ } else if (isPrevDumpFailoverReady) {
+ return false;
Review comment:
Yes, in that case, it won't be treated as valid dump and execution would
go to getCurrentDumpPath to resume the previous failed dump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 626368)
Time Spent: 6h 10m (was: 6h)
> Handle failover case during Repl Dump
> -------------------------------------
>
> Key: HIVE-24918
> URL: https://issues.apache.org/jira/browse/HIVE-24918
> Project: Hive
> Issue Type: New Feature
> Reporter: Haymant Mangla
> Assignee: Haymant Mangla
> Priority: Major
> Labels: pull-request-available
> Time Spent: 6h 10m
> Remaining Estimate: 0h
>
> To handle:
> a) Whenever user wants to go ahead with failover, during the next or
> subsequent repl dump operation upon confirming that there are no pending open
> transaction events, It should create a _failover_ready marker file in the
> dump dir. This marker file would contain scheduled query name
> that has generated this dump.
> b) Skip next repl dump instances once we have the marker file placed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
